Custom Build: Android overrides for min/target sdk #12148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build is failing. Maybe it's not supposed to be a string? Not sure |
3 tasks
|
Hmm, strange. It seems to work for me locally. Is there some other way to do this so it's not a string? |
DonLakeFlyer
force-pushed
the
AndroidOverrides
branch
from
06cca29
to
7861ae5
Compare
|
Option setting was backwards, duh! |
HTRamsey
approved these changes
Nov 29, 2024
|
Ah! I was wondering where this went. I just fixed it as well at the same time as you. |
|
Oh whoops my bad, I was in the middle of testing the new android stuff from the other PR somebody did so I went ahead and handled this too |
|
No problem at all. I was just confused when I couldn't find the open pull any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HTRamsey Can you double-check my cmake stuff? I think it's right, but i'm no cmake expert.