Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show close button when full screen #12099

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Only show close button when full screen #12099

merged 3 commits into from
Nov 27, 2024

Conversation

DonLakeFlyer
Copy link
Contributor

Related to #12091

This should prevent it from showing up on desktop builds in most cases
@DonLakeFlyer
Copy link
Contributor Author

@NiklasVoigt Can you give this a try on a SteamDeck once it builds?

@NiklasVoigt
Copy link
Contributor

@DonLakeFlyer can you provide an appimage?

@DonLakeFlyer
Copy link
Contributor Author

@HTRamsey
Copy link
Collaborator

@DonLakeFlyer I've realized this close button bypasses the "Are You Sure" checks when you are connected

@NiklasVoigt
Copy link
Contributor

NiklasVoigt commented Nov 21, 2024

@NiklasVoigt Can you give this a try on a SteamDeck once it builds?

It works as intended: In fullscreen mode, a close button is available; otherwise, there is no close button.

@NiklasVoigt
Copy link
Contributor

@DonLakeFlyer I've realized this close button bypasses the "Are You Sure" checks when you are connected

i think the button should better use checkForActiveConnections() instead of finishCloseProcess() ?

@DonLakeFlyer
Copy link
Contributor Author

OK, I’ll fix that

* Rework close sequence code to be clearer of state machine steps
* Fix app close button to use standard close sequence which checks for things like active connections
@DonLakeFlyer
Copy link
Contributor Author

@NiklasVoigt Can you test this again when it finishes building. I fixed the close sequence to always do the shutdown checks.

@NiklasVoigt
Copy link
Contributor

The functionality is as expected. On PC, no button is visible, whereas on the Steam Deck, a close button appears when in fullscreen mode.

@DonLakeFlyer
Copy link
Contributor Author

Great, thanks so much for helping out

@DonLakeFlyer DonLakeFlyer merged commit 9ee30e0 into master Nov 27, 2024
7 checks passed
@DonLakeFlyer DonLakeFlyer deleted the CloseFullScreen branch November 27, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants