-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show close button when full screen #12099
Conversation
This should prevent it from showing up on desktop builds in most cases
@NiklasVoigt Can you give this a try on a SteamDeck once it builds? |
@DonLakeFlyer can you provide an appimage? |
YOu can get it here: https://github.com/mavlink/qgroundcontrol/actions/runs/11863725486?pr=12099 |
@DonLakeFlyer I've realized this close button bypasses the "Are You Sure" checks when you are connected |
It works as intended: In fullscreen mode, a close button is available; otherwise, there is no close button. |
i think the button should better use checkForActiveConnections() instead of finishCloseProcess() ? |
OK, I’ll fix that |
* Rework close sequence code to be clearer of state machine steps * Fix app close button to use standard close sequence which checks for things like active connections
@NiklasVoigt Can you test this again when it finishes building. I fixed the close sequence to always do the shutdown checks. |
The functionality is as expected. On PC, no button is visible, whereas on the Steam Deck, a close button appears when in fullscreen mode. |
Great, thanks so much for helping out |
Related to #12091