Gimbal API redesign (support more than one gimbal, support streams and commands) #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
julianoes
commented
Jul 31, 2024
julianoes
commented
- Adding an argument for send mode (either command or message stream)
- Includes the mode into the setter because that's when it's sent. Otherwise, the set_mode call itself doesn't have any effect which is not very intuitive.
- Extend interface to support multiple gimbals.
This aims at improving the API by: - Adding an argument for send mode (either command or message stream) - Includes the mode into the setter because that's when it's sent. Otherwise, the set_mode call itself doesn't have any effect which is not very intuitive.
This will allow multiple gimbals to be controlled from just the one gimbal plugin instance. The goal is not to have multiple instances like it is (currently) done for cameras.
JonasVautherin
approved these changes
Aug 3, 2024
|
@JonasVautherin thanks for the review! |
julianoes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.