Add per-subscription setting to collapse all posts

[tivvit]

Hi, is it possible to format notifications? When I create new gitlab issue everything (title, link, content) is posted to the subscribed channel. Is it possible to customize those messages - I would like to omit content.

[tivvit]

I can see that it is not (

mattermost-plugin-gitlab/server/webhook/issue.go

Line 71 in 91c3584

message = fmt.Sprintf("#### %s\n##### [%s#%v](%s)\n###### new issue by [%s](%s) on [%s](%s)\n\n%s", issue.Title, repo.PathWithNamespace, issue.IID, issue.URL, senderGitlabUsername, w.gitlabRetreiver.GetUserURL(senderGitlabUsername), issue.CreatedAt, issue.URL, issue.Description)

), do you have any plans to support this feature?

[hanzei]

@tivvit What kind of customization do you have in mind? What is your use case?

[tivvit]

It would be great to be able to specify custom formatting string for each subscription.

For our team for example it would be sufficient to have something like this fmt.Sprintf("new issue %s %s %s\n", issue.Title, repo.PathWithNamespace, issue.URL) and we would probably track only issue creation and close (not tagging).

The use case is: we have company GitLab instance and Mattermost instance and we are using this plugin. We have a Mattermost team channel which is subscribed to several repositories for issues. We are quite happy about the notifications about new issues or issue changes, it simplifies team communication and it helps with our response time for issues created by other teams. But the information is very thorough - imagine an issue with long description (several paragraphs) and somebody adds a label to that issue which results in posting the whole issue text to the channel (again).

I am willing to help with the implementation but I would need some guidance with how to store per subscription settings and how to incorporate this (IMHO quite big) change into the codebase.

[tivvit]

I have redacted an example:

This happened a few minutes after the issue creation (which leads to reposting). It adds only very little information and in this example it is almost the whole screen.

And to be honest the text issue labeled ... is huge.

[tivvit]

We would very much like to use this also for merge requests, but the issue would be the same.

[hanzei]

@tivvit Would a plugin setting to disable issue/PR bodies solve your use case?

[tivvit]

It will definitely help. It is worth trying. Are you planning it per subscription?

[hanzei]

I was thinking about a global setting for all subscriptions

[tivvit]

We are a part of quite big deployment and I suppose there will be use-cases for both (with and without body)

[hanzei]

I see. The github plugin has the concept of flags which are passed on a subscription creation. E.g. a --short could be used. https://github.com/mattermost/mattermost-plugin-github/blob/d4bf39aef12c932bdf9c9bd3292ee67ecf9f6769/server/command.go#L30-L32

[tivvit]

flags for subscriptions sounds great

[tivvit]

hi guys, any progress on this?

[hanzei]

@tivvit Given you interested in this feature I'm wondering if you are interested in implementing it?

[tivvit]

@hanzei I am interested but I will not have time for this soon.

Can you please point to places in the code where it should be Implemented and describe briefly what has to be done for this feature because I am not familiar with this project.

After that, it will be simpler to do this effectively so someone may solve it i.e. for hacktoberfest. I am going to find time for this ASAP.

[hanzei]

@tivvit All events are handled in the webhook package in https://github.com/mattermost/mattermost-plugin-gitlab/tree/master/server/webhook. For the flag you should look into the Implementation in the GitHub plugin: mattermost/mattermost-plugin-github@23f77f0

[mickmister]

I propose we implement this as a --collapsed flag, as the issue in the GitHub plugin repo describes:

mattermost/mattermost-plugin-github#484