Add debug packet functionality #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the cloud plugin to request a debug packet for a given installation via the cloud provisioner. The packet currently contains pprof data for each Mattermost server instance in the server cluster.
mm-cloud-bot
added
the
release-note
gabrieljackson
added
2: Dev Review
nickmisasi
reviewed
Nov 28, 2024
Comment on lines
+39
to
+52
| p.API.SendEphemeralPost(extra.UserId, &model.Post{ | ||
| UserId: p.BotUserID, | ||
| ChannelId: extra.ChannelId, | ||
| Message: fmt.Sprintf("Gathering debug data for `%s` now. Please wait as this may take a while.", installToExec.Name), | ||
| }) | ||
|
|
||
| err = p.execGetDebugPacket(installToExec.ID, extra.UserId, name) | ||
| if err != nil { | ||
| return nil, false, err | ||
| } | ||
|
|
||
| resp := "Debug packet generated. Check your direct messages from the cloud bot." | ||
|
|
||
| return getCommandResponse(model.CommandResponseTypeEphemeral, resp, extra), false, nil |
There was a problem hiding this comment.
Should we wrap the exec in a go routine, so that a pprof that takes too long to generate won't run into timeout issues from Nginx?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the cloud plugin to request a debug packet for a given installation via the cloud provisioner. The packet currently contains pprof data for each Mattermost server instance in the server cluster.
Fixes https://mattermost.atlassian.net/browse/CLD-8609