Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support injected factory deps #674

Open
2 of 4 tasks
Karrq opened this issue Oct 29, 2024 · 1 comment
Open
2 of 4 tasks

Support injected factory deps #674

Karrq opened this issue Oct 29, 2024 · 1 comment
Labels
feature ➕ Feature item needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item

Comments

@Karrq
Copy link
Contributor

Karrq commented Oct 29, 2024

Users want to be able to inject a factory dep to a given contract, be it for tests or scripts and potentially deployments too.

We used to have this feature (partially) with #310, which was reworked into using information from the compiler in #316, but this is not sufficient when factory deps are not depended upon directly by the factory contract (thus the "injected" adjective)

Tasks:

  • Inject factory deps in broadcastable transactions (scripts)
  • Inject factory deps in tests
  • Inject factory deps in forge create
  • Inject factory deps in cast send --create
@Karrq Karrq linked a pull request Oct 29, 2024 that will close this issue
@Karrq Karrq removed a link to a pull request Oct 29, 2024
@Karrq
Copy link
Contributor Author

Karrq commented Oct 29, 2024

#671 will add support for the first 2 sub tasks

@Karrq Karrq added feature ➕ Feature item p1 🟠 Indicates high priority item labels Oct 29, 2024
@tomimor tomimor linked a pull request Oct 29, 2024 that will close this issue
@tomimor tomimor removed a link to a pull request Oct 30, 2024
@Jrigada Jrigada closed this as completed Oct 31, 2024
@Jrigada Jrigada reopened this Oct 31, 2024
@Jrigada Jrigada closed this as completed Oct 31, 2024
@Jrigada Jrigada reopened this Oct 31, 2024
@Jrigada Jrigada added the needs triage ♟️ Issue needs to be picked up or assigned label Oct 31, 2024
@Jrigada Jrigada removed their assignment Oct 31, 2024
@Jrigada Jrigada added p3 🔵 Indicates low priority item and removed p1 🟠 Indicates high priority item labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ➕ Feature item needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item
Projects
None yet
Development

No branches or pull requests

2 participants