Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop in log format detection #304

Open
sth opened this issue Jan 24, 2021 · 0 comments · May be fixed by #305
Open

Infinite loop in log format detection #304

sth opened this issue Jan 24, 2021 · 0 comments · May be fixed by #305

Comments

@sth
Copy link

sth commented Jan 24, 2021

import_logs.py gets stuck in an infinite loop in log format detection in this example (Matomo v4.1.1):

echo '# test' > somefile
python3 misc/log-analytics/import_logs.py --url=http://localhost/ somefile

It tries to read lines at end of file in this loop:

matomo-log-analytics/import_logs.py

Lines 291 to 295 in 7861399

while fields_line is None:
line = file.readline().strip()
if not line:
continue

@sth sth linked a pull request Jan 24, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix infinite loop in format detection sth/matomo-log-analytics
1 participant
@sth