Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application mouse ("tracking") modes: right-click still captured #388

Open
mined opened this issue May 31, 2021 · 0 comments · May be fixed by #461
Open

application mouse ("tracking") modes: right-click still captured #388

mined opened this issue May 31, 2021 · 0 comments · May be fixed by #461

Comments

@mined
Copy link

mined commented May 31, 2021

Expected behaviour

In application mouse modes, mouse events should be propagated to the application as escape sequences.
Works fine in lxterminal, gnome-terminal, xfce4-terminal.

Actual behaviour

This works with left and middle button and wheel scroll but right-click is still captured by the terminal which opens its own menu.

Steps to reproduce the behaviour

echo -e "\e[?1000h", then right-click

MATE general version

Package version

mate terminal 1.24.1

Linux Distribution

Debian 10

NP-Hardass added a commit to NP-Hardass/mate-terminal that referenced this issue Sep 21, 2024
Currently, the popup menu is shown for all right clicks that don't have
Ctrl, Alt, or Shift.  This is the opposite of what is done in every
other terminal.  The right click should go to the underlying application
except when a special modifier is used.  Gnome utilizes Shift as the
modifier and LXDE uses Ctrl as their modifier.

Referencing gnome-terminal-3.40:
https://github.com/GNOME/gnome-terminal/blob/gnome-3-40/src/terminal-screen.c#L1779C1-L1811C16 we can port this logic over and then we achieve exactly
what we are looking for. If there is no application, the terminal
handles the right click normally.  If there is an application, the click
gets passed through unless Shift is held.

Closes mate-desktop#388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant