Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netspeed unusable on vertical panels #1411

Open
pF-arQon opened this issue Oct 15, 2023 · 5 comments
Open

netspeed unusable on vertical panels #1411

pF-arQon opened this issue Oct 15, 2023 · 5 comments

Comments

@pF-arQon
Copy link

Expected behaviour

netspeed accurately displays network activity

Actual behaviour

netspeed displays what is effectively random numbers
netspeed-oof

Is that 5 megabits? 85? 965? Your guess is as good as mine. :)

Steps to reproduce the behaviour

Create a vertical panel, add the netspeed applet to it.

MATE general version

1.26

Package version

Linux Distribution

Ubuntu 22.04

Link to bugreport of your Distribution (requirement)

https://bugs.launchpad.net/ubuntu/+source/mate-applets/+bug/1841854 , which contains fixes for both this and the icon positioning bug

@lukefromdc
Copy link
Member

lukefromdc commented Oct 16, 2023

I just tested a bunch of left panel widths, and found that this applet simply does not manage space well when confined horizontally. The minimum width necessary to allow the applet to be useful would be the amount needed to accomodate the decimal places though, it's never going to be possible to make it very useful on say, a 24 px vertical panel.

Three things could help though: shrinking instead of cutting the icon, being able to remove the units or place the units label under the numbers, and maybe ellipsizing the label text so that the least significant figure would always be the first to go, even with the panel on the right side of the screen.

Anyway, here's what I got:

On a 100px left panel:
Netspeed_0n_100px_Panel

On a 76px left panel
Netspeed_0n_76px_Panel

On a 56 px left panel:
Netspeed_0n_56px_Panel

On a 36 px left panel:
Netspeed_0n_36px_Panel

@pF-arQon
Copy link
Author

Yeah, there are multiple issues with the code, though the icon problems are minor compared to the applet being literally nonfunctional since the 1.26 regression.

Like I say, all the bugs I've seen so far are fixed in the patches I posted six weeks ago, including the icon: they just need someone to actually merge them. There's not much point discussing cosmetic changes while even the most basic pieces are still broken, because the situation will be different once those are working.

@lukefromdc
Copy link
Member

lukefromdc commented Nov 30, 2023 via email

@pF-arQon
Copy link
Author

In the first post:

https://bugs.launchpad.net/ubuntu/+source/mate-applets/+bug/1841854 , which contains fixes for both this and the icon positioning bug

There are more bugs with it - as you say, it's just not very good at coping with spacing/orientation - but my time is limited so I had to prioritize making it functional first.

@lukefromdc
Copy link
Member

We cannot test and merge a PR from launchpad etc w/o manually cutting and pasting it into a PR ourselves. If you could do that we could then much more easily test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants