Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coco theme] inconsistent margin/padding #116

Open
aoreucro opened this issue Dec 18, 2016 · 0 comments
Open

[Coco theme] inconsistent margin/padding #116

aoreucro opened this issue Dec 18, 2016 · 0 comments

Comments

@aoreucro
Copy link

aoreucro commented Dec 18, 2016

The Coco theme text area has more padding on the top than the bottom, making the notifications look goofy. This is most noticeable with a simple notification like that produced with the following command:
notify-send 'Test';

inconsistent-margin-padding

I believe the issue is line 447 of /src/themes/coco/coco-theme.c:
gtk_widget_set_margin_start (vbox, 8);

The above is setting a top margin without a corresponding bottom margin (unlike the matching lines 428 and 429). I believe the solution is to add a call to gtk_widget_set_margin_end. Further, as I've also noticed that the top margin is a few pixels more than the side margins, it seems like the current margin should be split between the top and bottom. So line 447 would be replaced with:

gtk_widget_set_margin_start (vbox, 4);
gtk_widget_set_margin_end (vbox, 4);

Also, when an icon is included, the spacing to the left of the content (the content consisting of the combination of image and text) is less than the spacing to the right. I believe line 93 is the culprit:
#define IMAGE_PADDING 10

inconsistent-margin-padding-2

The above is from:
notify-send --icon=gucharmap 'Test' '________________________________________________________';

I think line 93 needs to be changed to:
#define IMAGE_PADDING 15

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/40183790-coco-theme-inconsistent-margin-padding?utm_campaign=plugin&utm_content=tracker%2F1172660&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1172660&utm_medium=issues&utm_source=github).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant