Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch compatible install #20

Closed
cardil opened this issue Feb 27, 2023 · 1 comment
Closed

Batch compatible install #20

cardil opened this issue Feb 27, 2023 · 1 comment

Comments

@cardil
Copy link

cardil commented Feb 27, 2023

The install command should be batch-compatible. Currently, it asks ! Rename the binary?, which prevents automation, and batch usage.

One way to fix this may be a --rename (or --as) option for install command:

$ stew install knative-sandbox/kn-plugin-event --as kn-event
knative-sandbox/kn-plugin-event
⬇️  Downloading asset: 100% |██████████████████████████████████████████████████████████| (57/57 MB, 34.474 MB/s)        
✅ Downloaded kn-event-linux-amd64 to /home/ksuszyns/.local/share/stew/pkg
📄 Updated /home/ksuszyns/.local/share/stew/Stewfile.lock.json
✨ Successfully installed the kn-event binary in /home/ksuszyns/bin

Alternative, could be a format of the installation. For example:

$ stew install knative-sandbox/kn-plugin-event!kn-event
@marwanhawari
Copy link
Owner

marwanhawari commented Apr 7, 2024

This is addressed by the new ability to have reproducible batch installs from the Stewfile.lock.json (#15, #35, #42, #43). This was a part of the v0.4.0 release.

I decided to make the Stewfile.lock.json the mechanism for these batch installs rather than the Stewfile. Stewfiles are nice for passing around machines with different OS/Arch's, but for reproducible, headless batch installs, users should use the lockfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants