This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Follow edis' means of adding facets based on mime types. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kghmanuel
commented
Jul 20, 2016
kghmanuel
commented
- Also included media/mediaTypes as well.
- Expanded the list of mime-types to watch out for
…ia/mediaType as "attachment type"
| <match pattern="application/mbox"/> | ||
| </group> | ||
| <group label="Others"> | ||
| <match pattern=".+"/> |
There was a problem hiding this comment.
show-remaining includes records without attachments/media which doesn't really fit. Not sure on how ml-constraints handles this yet, but the goal is to group the remaining valid and unknown mime-types here.
2. integrate deploy_packages to roxy as per readme of mlpm 3. remove "Others" in attachment type facets, not working. current limitation of ml-constraints. 4. use actual patterns/wildcards to reduce the number of patterns to compare.
|
Looks really good. Anyone with some spare cycles willing to run a quick test with this? |
|
Things have been moving slowly due to holidays. Still need to run a quick test with this.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.