Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter branches #35

Closed
morph027 opened this issue Jan 16, 2017 · 2 comments
Closed

Filter branches #35

morph027 opened this issue Jan 16, 2017 · 2 comments
Assignees

Comments

@morph027
Copy link

First of all, thanks for your work!

Can we add the ability to filter branches somehow (we are using on premise Gitlab)? We want to monitor same branch on different slugs. Devs should keep an eye on their own branches locally ;)

@marcells marcells self-assigned this Jan 16, 2017
@marcells
Copy link
Owner

marcells commented Jan 16, 2017

Thank you. :-)

Hm, your request is similar to #26. I don't want to be dependent on the underlying VCS, cause the build-monitor is very common and should work for all build systems/configurations in the same way.

Maybe a general property details.repository with an object (which isn't displayed, but can be filtered) could be possible. I'll then extend the filter in the frontend to respect the values (not the keys) of this property, too.

Is it possible for you to implement the property and make a pull request? Here's the correct place: https://github.com/marcells/node-build-monitor/blob/master/app/services/GitLab.js#L164
It should look like this:

return {
            ...
            url: getBuildUrl(project, build),
            details: {
                  repository: getRepositoryDetails(...) // should return { branch: 'master' } or { }, if no details exist
             }
        };

I'll extend the frontend, when you've finished. Okay?

EDIT:
If it's easy to implement, you can return the id, short_id and message, too.

@morph027
Copy link
Author

Thanks,sure, I'm gonna try this and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants