Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render project and user avatars #25

Open
LeoHuckvale opened this issue Aug 17, 2016 · 3 comments
Open

Render project and user avatars #25

LeoHuckvale opened this issue Aug 17, 2016 · 3 comments

Comments

@LeoHuckvale
Copy link

LeoHuckvale commented Aug 17, 2016

It might be useful to render project avatars (and possibly users) next to builds. This should make it easier to recognise specific projects when you have several on the screen.

This might not be available in all services (would require some research - will collate list here if needed).

GitLab

@marcells
Copy link
Owner

Good idea. It's a bigger change. I will think about about a solution. Currently the monitor it self could be reached from the outside, while the build servers are only accessible in the intranet. In this situation the image urls would break. To be consistent the avatar images have to be forwarded by the monitor.

@LeoHuckvale
Copy link
Author

Yes, I hadn't considered that - I guess you'd rather not be storing images anywhere.

Similar problem outlined in this Stack Overflow question - the solution seems to be to have a route on the server to dynamically obtain the image from the private source. I suppose in this instance you'd have to implement it differently for each service, but you'd be doing that anyway...

@marcells
Copy link
Owner

Thanks. That's exactly the way, I already considered how to implement it. ;-) I think, I will add a general option to turn this feature off. Maybe the avatar pics don't match to visual design of the monitor for some users. Now I just need time to implement it. ;-)

@marcells marcells self-assigned this Aug 18, 2016
@marcells marcells removed their assignment Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants