Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vectorized_delta doesn't call numerical_delta_black correctly #3

Closed
m1jkf00 opened this issue Mar 27, 2021 · 3 comments
Closed

vectorized_delta doesn't call numerical_delta_black correctly #3

m1jkf00 opened this issue Mar 27, 2021 · 3 comments

Comments

@m1jkf00
Copy link

m1jkf00 commented Mar 27, 2021

Thank you for this package!

When I try to calculate Black deltas using vectorized_delta, it returns an error that numerical_delta_black was passed an unexpected bs argument. I've patched this in my versions of the file by just adding "bs" as an argument to the numerical function, though it probably would have been better to stop greeks.delta from passing the bs argument in the first place.

@marcdemers
Copy link
Owner

Hi @m1jkf00 , thanks for the bug report. I will fix this in a new version. I kept the delta functions' signatures standardized, which is why I still pass the "bs" arguments to black model.

@ccagrawal
Copy link

I'm sure you are aware, but the same is true for the other greeks (e.g. numerical_vega_black and numerical_gamma_black).

@marcdemers
Copy link
Owner

resolved by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants