Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of iterations different than stated #151

Open
CIWa opened this issue Oct 5, 2021 · 3 comments
Open

Number of iterations different than stated #151

CIWa opened this issue Oct 5, 2021 · 3 comments

Comments

@CIWa
Copy link

CIWa commented Oct 5, 2021

Hi,
I would like to report that Salsa still seems to sometimes run more iterations than stated in the call. More precisely, I requested the default number of iterations (3), but Salsa ran 5.
My call was:

run_pipeline.py -a assembly.fa -l assembly.fa.fai -b alignment.bed -o ./ -e DNASE -m yes

Could be the same problem as in issue #29?
Best wishes,
Isabel

@oneillkza
Copy link

Yep I'm having the same issue -- SALSA always runs 5 iterations (well, maybe 4 -- it looks like "iteration 1" is just the baseline assembly). This is different from the default of 3 mentioned in the docs, and seems to ignore the -i parameter completely.

It even seems to be slightly stochastic -- one time I ran it with -i 7 it ran for five iterations. Another time it ran for four.

@skoren
Copy link
Member

skoren commented Nov 5, 2021

@ghuryejay can confirm but I'm pretty sure the iteration parameter is no longer used. As described in the manuscript for SALSA2, the stopping condition is dynamically determined based on when the majority of new links are bad or the assembly is not changing.

@oneillkza
Copy link

oneillkza commented Nov 5, 2021

Thanks for the explanation @skoren ! It might be good to update the documentation/remove the parameter.

And is there any way to fine-tune when it stops? I have an assembly I've scaffolded with SALSA, which from the final contact map looks very good, but it's visually clear that there are a few more scaffolds that could be joined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants