Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thicken duplicate edges #231

Open
fedarko opened this issue Apr 29, 2022 · 1 comment
Open

Thicken duplicate edges #231

fedarko opened this issue Apr 29, 2022 · 1 comment
Labels
bug hierarchical decomposition it took me a year to implement this so it had better be useful .___.

Comments

@fedarko
Copy link
Member

fedarko commented Apr 29, 2022

i.e. edges between a node and its duplicate, for bubble boundaries. These seem to be weirdly small -- I suspect something's going wrong.
@fedarko fedarko added bug hierarchical decomposition it took me a year to implement this so it had better be useful .___. labels Apr 29, 2022
@fedarko
Copy link
Member Author

fedarko commented May 2, 2022

quick surface-level patch: just modify the js style for edge.is_dup as follows:

{
    selector: "edge.is_dup",
    style: {
        "line-style": "dashed",
        width: 15
    },
},

fedarko added a commit to fedarko/MetagenomeScope-1 that referenced this issue May 2, 2022
@fedarko
temporarily address marbl#231
6bdc3c9 
Hmmmm, so is the issue closeable or not?

I guess in the ideal case the data(thickness) edge style doesn't
apply to all edges, just non-dup edges, and then there's no risk
of redundancy or whatevs. but for now this solution works fine
(and i actually kinda line the new way dup edges are styled, they're
like big slinkies -- calls out the fact that they're not real).
fedarko added a commit that referenced this issue May 2, 2022
@fedarko
temporarily address #231 (#232)
fad3f8b 
Hmmmm, so is the issue closeable or not?

I guess in the ideal case the data(thickness) edge style doesn't
apply to all edges, just non-dup edges, and then there's no risk
of redundancy or whatevs. but for now this solution works fine
(and i actually kinda line the new way dup edges are styled, they're
like big slinkies -- calls out the fact that they're not real).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hierarchical decomposition it took me a year to implement this so it had better be useful .___.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fedarko