-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fe updates from UCI #464
base: development
Are you sure you want to change the base?
Fe updates from UCI #464
Commits on Sep 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 70afe1f - Browse repository at this point
Copy the full SHA 70afe1fView commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 97bbb1b - Browse repository at this point
Copy the full SHA 97bbb1bView commit details -
Fix code consistency issues in Fortran
Cleaned up some trailing white space, converted hard tabs to soft, and added a few missing _r8 modifiers
Configuration menu - View commit details
-
Copy full SHA for 9422a43 - Browse repository at this point
Copy the full SHA 9422a43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 961ca65 - Browse repository at this point
Copy the full SHA 961ca65View commit details -
Re-enable Fe balance check, clean up code
Stand-alone build found some unused variables and imports that I removed
Configuration menu - View commit details
-
Copy full SHA for 6681874 - Browse repository at this point
Copy the full SHA 6681874View commit details
Commits on May 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for caf8308 - Browse repository at this point
Copy the full SHA caf8308View commit details -
Update the 4p2z settings file and input files
Also removed trailing whitespace I inadvertantly added to marbl_diagnostics_mod in the last commit
Configuration menu - View commit details
-
Copy full SHA for b51320f - Browse repository at this point
Copy the full SHA b51320fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3a3cdb - Browse repository at this point
Copy the full SHA d3a3cdbView commit details
Commits on May 25, 2024
-
Clean up variable P:C and N:C logic
Some settings in marbl_settings_mod.F90 only need to be defined if lvariable_PtoC (or NtoC) is true. Also, found a couple block in marbl_init_tracer_metadata_mod.F90 that wasn't verifying N_ind > 0 before modifying N tracers (N_ind = 0 if lvariable_NtoC = .false.)
Configuration menu - View commit details
-
Copy full SHA for 46a90f6 - Browse repository at this point
Copy the full SHA 46a90f6View commit details -
For cesm2.0 and cesm2.1 (3p1z or 4p1z), add lvariable_NtoC but set the default to .false.; also renamed gQfe_0 -> gQfe_max and added the non-N settings from the settings_latest files.
Configuration menu - View commit details
-
Copy full SHA for 123888a - Browse repository at this point
Copy the full SHA 123888aView commit details -
Add most of the new settings to SPECRTA file
Don't know what to use for Qn_fixed, waiting to hear back from UCI and NOAA folks... so this will still fail the init.py test (but with fewer MARBL ERROR lines)
Configuration menu - View commit details
-
Copy full SHA for e04257d - Browse repository at this point
Copy the full SHA e04257dView commit details -
Add fixed_NtoC settings file for testing
Also generate the 4p2z settings file from JSON as part of testing
Configuration menu - View commit details
-
Copy full SHA for f771fd6 - Browse repository at this point
Copy the full SHA f771fd6View commit details
Commits on May 30, 2024
-
Remove Qn_fixed from autotroph_settings_type
After discussion with Keith L, it looks like Qn_fixed and Qn_zoo were added to the code base so the fixed N:C configuration looked more like the fixed P:C configuration... but it isn't necessary since we want to use the same fixed N:C throughout the code (as opposed to fixed P:C, which really does vary from among the different functional types even when fixed spatially / temporally)
Configuration menu - View commit details
-
Copy full SHA for df02542 - Browse repository at this point
Copy the full SHA df02542View commit details
Commits on Jun 4, 2024
-
Changes to pass call_compute_subroutines tests
Modify marbl_io_mod to initialize N tracers to C tracers * 16/112 and set feredsedflux and feventflux = 0. Modify marbl_diagnostics_mod.F90 to include dust%remin*dust_to_Fe in integrand, not righthand-side of iron conservation check Modify marbl_interior_tendency_mod.F90 to sflux_in * desportion in P_iron%remin before computing sflux_out. Also cleaned up a few small things in interior_tendency_mod (use unit_system instead of assuming cgs; initialize Lig_prod and declare it as inout in some routines)
Configuration menu - View commit details
-
Copy full SHA for be7794d - Browse repository at this point
Copy the full SHA be7794dView commit details -
initialize coccoN by scaling spC
no coccoC in this initial condition file, but coccoC = 0.07*spC
Configuration menu - View commit details
-
Copy full SHA for 9733088 - Browse repository at this point
Copy the full SHA 9733088View commit details