Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/v2/task/:taskId/review/start returns 500 if a review row isn't found #1090

Open
jschwarz2030 opened this issue Dec 6, 2023 · 0 comments

Comments

@jschwarz2030
Copy link
Collaborator

jschwarz2030 commented Dec 6, 2023

example request

GET | https://staging.maproulette.org/api/v2/task/170921569/review/start?mapillary=false

returns an ambiguous 500 error

message | "SqlMappingError(No rows when expecting a single one)"

This could be refined into something easier to understand for API users. I happened to run into this while going through a flow that isn't typically used by maproulette UI users (it's more of a modified dev flow for testing review pages). Regardless, here are the steps to reproduce...

Have 2 users, each logged in a different browser

Your User 1

  1. start a task
  2. mark 'Not an Issue'
  3. In the confirmation modal, DO NOT check 'Request Review'
  4. copy the URL
  5. Press submit

Your User 2
6. paste the URL in a user 2's separate browser, adding /review to the end of it. submit the URL by pressing Enter
7. you should see the error, presented in the UI as 'Someone else is reviewing this challenge', which is false information (possible followup UI ticket).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant