From 52501a16f9a08241f3de1fa7b2def8e1f83a15c4 Mon Sep 17 00:00:00 2001
From: Bart Louwers <bart.louwers@gmail.com>
Date: Tue, 15 Oct 2024 13:58:00 +0200
Subject: [PATCH] Fix CMake config

---
 CMakeLists.txt | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 22a3a8a..9ad5f26 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -36,15 +36,18 @@ add_executable(unit-tests ${TEST_SOURCES})
 
 Include(FetchContent)
 
-#https://github.com/catchorg/Catch2/issues/2583
+# SYSTEM property is not propagated so
+# set these globally ¯\_(ツ)_/¯
+# https://gitlab.kitware.com/cmake/cmake/-/issues/25364
 add_compile_options(-Wno-error=conversion)
 add_compile_options(-Wno-error=sign-conversion)
+add_compile_options(-Wno-error=non-virtual-dtor)
 
 FetchContent_Declare(
   Catch2
   GIT_REPOSITORY https://github.com/catchorg/Catch2.git
   GIT_TAG        v3.7.1
-  SYSTEM  # https://gitlab.kitware.com/cmake/cmake/-/issues/25364
+  SYSTEM
 )
 FetchContent_MakeAvailable(Catch2)