Fix behaviour on PPC64EL #761
Conversation
Double, while calculating abs(det) is promoted to int on ppc64el, so that the modified condition always held. Since abs from cmath also returns wrong result, I've fixed it as follows.
|
Hi @piotrmaslanka! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
After much combat we (Dronehub) managed to get opensfm to work on ppc64el.
Double, while calculating abs(det) is promoted to int on ppc64el, so that previously the condition that has been changed always held true.
I've fixed it as follows