Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github action dependency upgrades on 2024-07-31 #516

Merged
merged 1 commit into from
Jul 31, 2024
Merged

github action dependency upgrades on 2024-07-31 #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ai-revision.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ jobs:
shell: bash --login {0}
steps:
- name: Checkout Repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ inputs.branch }}
- name: Install environment
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Install Manubot AI revision dependencies
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/manubot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
shell: bash --login {0}
steps:
- name: Checkout Repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# fetch entire commit history to support get_rootstock_commit
fetch-depth: 0
Expand All @@ -72,14 +72,14 @@ jobs:
echo "DEFAULT_BRANCH_REF=refs/heads/$DEFAULT_BRANCH" >> $GITHUB_ENV
echo "DEFAULT_BRANCH=$DEFAULT_BRANCH"
- name: Cache
uses: actions/cache@v3
uses: actions/cache@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes at https://github.com/actions/cache/releases/tag/v4.0.0

with:
path: ci/cache
key: ci-cache-${{ github.ref }}
restore-keys: |
ci-cache-${{ env.DEFAULT_BRANCH_REF }}
- name: Install Environment
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes at https://github.com/conda-incubator/setup-miniconda/releases/tag/v3.0.0

with:
activate-environment: manubot
environment-file: build/environment.yml
Expand All @@ -93,7 +93,7 @@ jobs:
- name: Build Manuscript
run: bash build/build.sh
- name: Upload Artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/actions/upload-artifact/releases/tag/v4.0.0
https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/

Copy link
Member Author

@dhimmel dhimmel Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the log output from the upload artifact step

With the provided path, there will be 9 files uploaded
Artifact name is valid!
Root directory input is valid!
Beginning upload of artifact content to blob storage
Uploaded bytes 215686
Finished uploading artifact content to blob storage!
SHA256 hash of uploaded artifact zip is 470397e4848ba4fd526b226d5b9879e1553ae8e665f5dbb1b8e9b357e5375d94
Finalizing artifact upload
Artifact manuscript-10[18](https://github.com/manubot/rootstock/actions/runs/10185388467/job/28174854640#step:9:19)5388467-08f8521.zip successfully finalized. Artifact ID 1761448987
Artifact manuscript-10185388467-08f8521 has been successfully uploaded! Final size is [21](https://github.com/manubot/rootstock/actions/runs/10185388467/job/28174854640#step:9:22)5686 bytes. Artifact ID is 1761448987
Artifact download URL: https://github.com/manubot/rootstock/actions/runs/10185388467/artifacts/1761448987

Note that this step now outputs artifact-url, which it did not in past. We possibly could now remove AppVeyor since GitHub Actions can presumably comment with the artifact link.

with:
name: manuscript-${{ github.run_id }}-${{ env.TRIGGERING_SHA_7 }}
path: output
Expand Down