Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues #246

Open
lbayle opened this issue Mar 16, 2018 · 14 comments
Open

Performance issues #246

lbayle opened this issue Mar 16, 2018 · 14 comments

Comments

@lbayle
Copy link
Member

lbayle commented Mar 16, 2018

Hi,
Firefox complains about a page slowing down the browser.
It takes a long time to display the "Assignment board" (+200 issues to display)

Very promissing tool, we already love it !

@thanhhungtn1
Copy link

+1 for this issue, we have 280 tickets under the filter of My View page and it took forever to load.
Please fix this issue

@thanhhungtn1
Copy link

Further investigation is I only filtered out the status and the other filtered set to default. May some issue with the selecting datas queries?

@nenadalm
Copy link

nenadalm commented Feb 7, 2020

$t_per_page = -1;
is causing for me to that over 32 000 records per page is configured. Main document loads in 2.1 minutes and there are errors in js console, missing buttons on page and I see no tickets.

When I change $t_per_page to null it causes configuration of 50 records per page, main document loads in 7s but it still takes way longer to show some tickets. Records per page probably shouldn't be unlimited?

@nenadalm
Copy link

nenadalm commented Feb 7, 2020

Related to js performance I found that when commenting out this while:

while (resWidth > maxWidth || resHeight > maxHeight) {
rendering time drops by ~1min.

@nenadalm
Copy link

In case you're interested I started working on performance improvements: https://github.com/imatic/Taskodrome/commits/imatic_mantis2 for now js renders page with 50 records about 1minute faster (many long strings which this plugin was shortening quite a while).

@AuthenticEshkinKot
Copy link

Hello, @nenadalm !
Thank you for help! I'll check out your commits.

@nenadalm
Copy link

Do I understand it correctly that this plugin just renders all issues in mantis in selected project? So that if I have over 32000 issues, they will all be rendered at once (status doesn't matter) and there is no way to configure it?

@AuthenticEshkinKot
Copy link

Yes, this plugin gets all available issues of current project and tries to show them. Admin can hide some users or statuses with their issues using plugin configuration.

@nenadalm
Copy link

Plugin configuration won't affect number of rows from database though:

$rows = filter_get_bug_rows( $f_page_number, $t_per_page, $t_page_count, $t_bug_count, null, null, null, true );
right? So no matter what I configure, plugin will always fetch all 32 000 issues?

@AuthenticEshkinKot
Copy link

Yep, that's right

@nenadalm
Copy link

Ok, thanks. It turned out that this plugin is not something we would like to use. Feel free to merge in the performance improvements in case of tasks with long texts. I won't look more into this.

@AuthenticEshkinKot
Copy link

@nenadalm
Could you make a pull request with your improvements, please? It's your work, so it would be more fair if your account would be attached to it.

@nenadalm
Copy link

I don't think I can. I am getting redirections when trying to create PR: https://github.com/mantisbt-plugins/Taskodrome/compare/mantisbt-plugins:mantisbt_2.0.0...imatic:imatic_mantis2?expand=1 back to the create PR page. I don't really mind which account is attached to the changes :)

@AuthenticEshkinKot
Copy link

OK :)

AuthenticEshkinKot added a commit that referenced this issue Feb 10, 2020
Design of text shortening function was improved (issue #246)
AuthenticEshkinKot added a commit that referenced this issue Feb 10, 2020
Design of text shortening function was improved (issue #246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants