Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix holiday schedule for republicservices #3100

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

bbqandgames
Copy link

I commented on #1430 that I was having a similar issue. After some self doubt I decided to create a pull request. Below is my comment from the bug for convenience.

After I made the comment I called and spoke with a customer service rep and the confirmed what was on their site and my understanding of the issue.

After a lot of reviewing the Republic Waste site I found this:

Holiday schedules vary by service location. Residential collection may be delayed due to these and other holidays:

Memorial Day
July 4th
Labor Day
Thanksgiving Day
Christmas Day
New Year's Day

Holidays typically push our residential pickup schedules back one day with regular schedules resuming the following > week.

Currently, the integration is showing my garbage pickup is December 2. However, since Thanksgiving is November 28 it is shifting to December 3. I believe based on their website shifting to a new week should “reset” the delay.

Now this may be a different issue than the original post since in that case it is moving it two days. I am curious if at that time the day after Thanksgiving was considered a holiday at that point in time. I have no way of knowing since it appears (both via api and browsing the Republic site) that this year it is not considered a holiday.

@5ila5
Copy link
Collaborator

5ila5 commented Nov 28, 2024

Thanks for your contribution

@5ila5 5ila5 merged commit 74e412a into mampfes:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants