Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support existingSecret refs in values file #55

Open
michaelfedell opened this issue Oct 14, 2024 · 4 comments
Open

Support existingSecret refs in values file #55

michaelfedell opened this issue Oct 14, 2024 · 4 comments

Comments

@michaelfedell
Copy link

Currently, the values.yaml for both helm charts requires sensitive values such as .Values.env.aws_secret_access_key, ...secre_key, ...pgdb_remote_url, etc. All of these values must be committed to a git repository if you are managing your deployment via GitOps (ArgoCD, FluxCD, etc.) which is not a good solution for anybody.

Many Helm charts solve this problem by supporting an existingSecret value so that any sensitive values can be passed directly to the helm chart (where they are often used to create a Secret), or can be set up in an existing secret (e.g. managed by External Secrets Operator, and simply referenced in the Helm values.

Here are a few examples of charts which do this well:

@michaelfedell
Copy link
Author

Actually, it looks like a lot of this work has already begun on the external-secrets branch. Does anyone have context on the state of that effort? it looks to be largely complete but only exists on the plane-ce version
develop...external-secrets

@theparthacus
Copy link
Collaborator

@mguptahub, could you see this, too? be good to ship this too in the next two weeks.

@mguptahub
Copy link
Collaborator

@michaelfedell

This is a good one to be added. Thanks for bringing it up. Will update you as we are ready to ship.

@leedsjb
Copy link

leedsjb commented Nov 30, 2024

@theparthacus @mguptahub can you provide an updated timeline for this issue please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants