Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: Add a verification code for the app as well (not user facing) #14

Open
BjarniRunar opened this issue Jul 12, 2022 · 0 comments

Comments

@BjarniRunar
Copy link
Member

Attack scenario:

Mallory has a copy of the Encrypted Data and Recovery Pack. Mallory is also able to eavesdrop on the channel over which
Verification Codes are sent (SMS, e-mail). Mallory would like to decrypt the Data without Alice being notified. If Mallory sees
that Alice has initiated recovery, Mallory will be able to silently request a Fragment from the server by reusing the same code
as was sent to Alice.

This attack can be thwarted if the VerificationResponse includes a random code which the app must present on Recovery, in addition to the code sent to the user. This has no user-facing implications, but does complicate the Passcrow Client, since it will need to keep state for in-progress recoveries.

This scenario assumes Mallory has quite a significant level of access already (e.g. access to Alice's backups, as well as Alice's online accounts) - but not total access: in this scenario Mallory has not compromised the Servers and doesn't have live access to Alice's devices. So it's a hole worth closing.

@BjarniRunar BjarniRunar changed the title security: Add a verification code for the app as well (not use facing) security: Add a verification code for the app as well (not user facing) Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant