-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EC2 launch templates #65
Comments
I don't think this is necessarily the case. Launch templates provide overrideable defaults for selected instance parameters (see docs), so this could be made an optional input (retaining backwards-compatibility). One could then e.g. override the instance type defined in the launch template (if any) by passing one thru the |
Yes, you're right, we can add one more input and retain the backward compatibility. But we can also go the other way by introducing v3 and make the action simpler, and as a result, more stable:
What do you think? |
I like simplicity, so that plan for That said, I do also like backwards-compatibility (even more so as this action seems to be quite widely used), so if we tested the launch template approach with |
That's actually a very good point! 🤔 |
@machulav Here's a quick CloudFormation template for setting up an EC2 launch template (I'd imagine something like this would help users adopt launch templates): https://gist.github.com/jpalomaki/003c4d173a856cf64c6d35f8869a2de8. Subnet is currently left optional, so we can test if automatic AZ assignment could help with #60, and spot/public IP settings are exposed as optionals. |
CloudFormation template now updated with most settings we have been looking at, including EBS, instance profile and example tags. I also tested it quickly with my Ubuntu AMI, seems to work. |
Thank you! I will test it and try to figure out more details of what we can cover with this and get back to you. |
Any updates to this? |
Сontinuation of the discussion started by @jpalomaki in #62 (comment)
Related issues that may be covered using the EC2 launch template approach:
The text was updated successfully, but these errors were encountered: