Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal_signal: fix overwriting OUT dir pin value #395

Merged
merged 1 commit into from
Jan 29, 2024
Merged

hal_signal: fix overwriting OUT dir pin value #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/hal/src/hal_signal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,10 @@ int halg_link(const int use_hal_mutex,
// good runtime assertion on 'halcmd show objects'.
pin->data_ptr = SHMOFF(&sig->value);

if (( sig->readers == 0 ) && ( sig->writers == 0 ) &&
( sig->bidirs == 0 )) {
if (( pin->dir == HAL_OUT ) || ( sig->readers + sig->writers + sig->bidirs == 0 )) {

// this signal is not linked to any pins
// or the newly linked pin is the first OUT pin
// copy value from pin's "dummy" field,
// making it 'inherit' the value of the first pin
// data_addr = hal_shmem_base + sig->data_ptr;
Expand Down
Loading