Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-machine tweaks in support of PR #13 #14

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

docker-machine tweaks in support of PR #13 #14

wants to merge 8 commits into from

Commits on Sep 19, 2019

  1. Moving minikube hyperkit changes upstream

    @sharifelgamal @dx9
    sharifelgamal authored and dx9 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    01bd201 View commit details
    Browse the repository at this point in the history

  2. remove minikube import

    @sharifelgamal @dx9
    sharifelgamal authored and dx9 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    244411c View commit details
    Browse the repository at this point in the history

  3. add missing files

    @sharifelgamal @dx9
    sharifelgamal authored and dx9 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    18a3d7e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Support various ISO kernel boot file layouts. 

    Search for boot files using patterns instead of hard coded paths.

Similar to the docker-machine-driver-xhyve approach.

Signed-off-by: John Coyle <[email protected]>
    @dx9
    dx9 committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    d6466b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. Don't set hyperkit package CPU and memory defaults with zero values. 

    Only set CPU or memory values when requested value is greater than the default.

Signed-off-by: John Coyle <[email protected]>
    @dx9
    dx9 committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    2258b94 View commit details
    Browse the repository at this point in the history

  2. Set a UUID based on the machine name when a UUID is unspecified. 

    Hyperkit uses this UUID to assign a MAC address that the driver is expecting. The driver searches for this MAC address in the DHCP lease file to resolve the machine.

Using a UUID based on machine name minimizes entries in the DHCP lease file. It also provides IP address consistency while the DHCP lease is valid.

Signed-off-by: John Coyle <[email protected]>
    @dx9
    dx9 committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    1582e49 View commit details
    Browse the repository at this point in the history

  3. Fix SSH using docker-machine 

    Set a default disk size. Move init of BaseDriver.SSHUser to Create() to avoid overwrite.

Signed-off-by: John Coyle <[email protected]>
    @dx9
    dx9 committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    0109dc5 View commit details
    Browse the repository at this point in the history

  4. Add some docker-machine config flags (boot2docker-url, disk-size, cpu… 

    …-count, memory-size).

Signed-off-by: John Coyle <[email protected]>
    @dx9
    dx9 committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    46602b1 View commit details
    Browse the repository at this point in the history