Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide wallet name and account name in Street Mode #946

Open
chaserene opened this issue May 19, 2024 · 2 comments
Open

hide wallet name and account name in Street Mode #946

chaserene opened this issue May 19, 2024 · 2 comments

Comments

@chaserene
Copy link

the wallet name and account name remain visible in the top bar in Street Mode. they serve no useful purpose in Street Mode, but they contain potentially sensitive information, so it's better to hide them.

@anhdres
Copy link
Contributor

anhdres commented Jun 25, 2024

I'm not sure about this.

We'd lose all reference for the user to know which wallet is open. I think if you're interacting in person you should not have a very sensitive wallet name anyway unless you open the wallet from the main screen outside of the other person's sight.

If @m2049r doesn't think it's cumbersome for the code, I guess it could be an "advance setting" not on by default which says:

Hide wallet and account names in Street Mode

But I don't think it should be the default setting.

@chaserene
Copy link
Author

I thought the point of Street Mode is to hide as many non-critical reference points as possible. I agree you shouldn’t have sensitive wallet and account names, but what’s sensitive varies across environments. I also think that you as the user will remember which wallet and account you have opened. after all, Street Mode is something you activate when you prepare to use a certain wallet in a higher-risk environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants