-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream vale port type extraction #569
base: master
Are you sure you want to change the base?
Upstream vale port type extraction #569
Conversation
Sync to head.
Sync from master.
…19-upstream-vale-port-type-extraction to master * commit '0611cef314f524741c9ea3ad80bf3cd85634cc1a': Change constant names to reflect upstream standards. Add port type information to vale-ctl output. Add additional checks to identify a vale Physical port Add a port type return value for NETMAP_BDG_LIST command
@@ -324,6 +324,7 @@ nmreq_to_legacy(struct nmreq_header *hdr, struct nmreq *nmr) | |||
strlcpy(nmr->nr_name, hdr->nr_name, sizeof(nmr->nr_name)); | |||
nmr->nr_arg1 = req->nr_bridge_idx; | |||
nmr->nr_arg2 = req->nr_port_idx; | |||
nmr->nr_arg3 = req->nr_port_type; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is legacy API, and therefore can't be changed.
VALE_PORT_T_ERROR = 0, | ||
VALE_PORT_T_PHYS = 1, | ||
VALE_PORT_T_STACK = 2, | ||
VALE_PORT_T_VIRT = 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we distinguish between ephemeral vale ports and persistent vale ports (e.g. created with vale-ctl -n
?)
Hi, A better approach is to add an Once we do this, we can extend the |
Adds some logic which we have found to be useful. Namely, provide a way to determine what type of VALE port we are dealing with. This is useful to identify configuration issues or to be able to take different actions based on where the data is coming from.