Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the log file, fixed bad update grep (UNIX) #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chris-blackburn
Copy link

For many projects, I have tag files already generated, so I'd like to just update those. However, I noticed that gutentags would only update tag files it generated. The regex pattern used to find the changed file wasn't working for some reason, so I updated it.

I also updated the script to use the log file it wasn't previously using.

For many projects, I have tag files already generated, so I'd like to just update those. However, I noticed that gutentags would only update tag files it generated. The grep command used to remove files wasn't working for some reason, so I updated it. I also updated the script to use the log file it wasn't previously using.
@ludovicchabant
Copy link
Owner

Hi and thanks for the PR!

I didn't know about those special bracketed names for grep's regex engine, that's nice, thanks. I'm not sure what your regex changes though -- before, it was skipping over any non-tab character up to the first tab, and now you're matching any alpha-numeric character up to the first whitespace. So AFAICT it will fail if a symbol has non-alpha-numeric characters (unlikely, but worth noting) but will also match if the whitespace after it isn't a tab (unlikely, I think that's part of the ctags standard?).

I don't understand what you're doing with the redirections, too. Looking it up, I think this use of exec only works in bash and ksh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants