Skip to content

Commit

Permalink
DM-47795: adjusting test case for the new wait, adding news fragment.
Browse files Browse the repository at this point in the history
  • Loading branch information
kfanning committed Nov 25, 2024
1 parent e90ef1b commit 1d09688
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
1 change: 1 addition & 0 deletions doc/news/DM-47795.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
IN ``mtcs.py``, wait for both primary and secondary bump tests to finish to avoid a race condition where the last actuator has its test cancelled due to exiting engineering mode on M1M3.
13 changes: 0 additions & 13 deletions tests/maintel/test_mtcs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1707,19 +1707,6 @@ async def test_run_m1m3_actuator_bump_test_both_fail(self) -> None:
secondary_status,
) = await self.mtcs.get_m1m3_bump_test_status(actuator_id=actuator_id)

assert primary_status == idl.enums.MTM1M3.BumpTest.FAILED
assert secondary_status != idl.enums.MTM1M3.BumpTest.FAILED

with pytest.raises(RuntimeError):
await self.mtcs._wait_bump_test_ok(
actuator_id=actuator_id, primary=False, secondary=True
)

(
primary_status,
secondary_status,
) = await self.mtcs.get_m1m3_bump_test_status(actuator_id=actuator_id)

assert primary_status == idl.enums.MTM1M3.BumpTest.FAILED
assert secondary_status == idl.enums.MTM1M3.BumpTest.FAILED

Expand Down

0 comments on commit 1d09688

Please sign in to comment.