Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sparse zernikes to be used from ts_wep. #15

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Enable sparse zernikes to be used from ts_wep. #15

merged 2 commits into from
Nov 17, 2024

Conversation

jbkalmbach
Copy link
Member

No description provided.

jfcrenshaw
jfcrenshaw approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@jfcrenshaw jfcrenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you haven't already, you should test this on USDF where you specify a sparse set of Zernikes and make sure everything runs and the plots look correct

python/lsst/donut/viz/zernike_pyramid.py Outdated Show resolved Hide resolved
python/lsst/donut/viz/zernike_pyramid.py Outdated Show resolved Hide resolved
@jbkalmbach
Copy link
Member Author

image

Looks good. Made changes suggested above.

@jbkalmbach jbkalmbach merged commit fb6bc07 into main Nov 17, 2024
3 checks passed
@jbkalmbach jbkalmbach deleted the tickets/DM-47495 branch November 17, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfcrenshaw jfcrenshaw jfcrenshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbkalmbach @jfcrenshaw