[sival,spi_host] Fix tag on Macronix flash SiVal test #25457
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
added
the
CherryPick:earlgrey_1.0.0
engdoreis
approved these changes
Nov 29, 2024
This will properly tie the tag to the test (and not just to the execution environment, which does nothing, due to the implementation of `_hacky_tags` used in `opentitan_test`), so that the test will run in the nightly SiVal job. Signed-off-by: Alex Jones <[email protected]>
AlexJones0
force-pushed
the
spi_macronix_tag_fix
branch
from
d30c421
to
59a5645
Compare
|
Force push is just a buildifier lint to pass CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will properly tie the tag to the test (and not just to the execution environment, which does nothing, due to the implementation of
_hacky_tagsused inopentitan_test), so that the test will run in the nightly SiVal job. See discussion here for more explanation.Supercedes #25447 as per request by @engdoreis.