[alert,dv] Tidyups in the alert receiver driver #25430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was "tightened up" in commit b1095ff, which actually broke things! The problem is that I was imagining the "continue" would continue in the surrounding "forever" loop. But it doesn't! It just skips an iteration of the "repeat" loop inside. Make the logic a bit more explicit and correctly handle the case where we go into reset with the clock paused. Signed-off-by: Rupert Swarbrick <[email protected]>
This is pretty much a mechanical change, but should make it a bit easier to read the file and to place documentation comments. Signed-off-by: Rupert Swarbrick <[email protected]>
Signed-off-by: Rupert Swarbrick <[email protected]>
Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
added
Component:DV
rswarbrick
requested review from
matutem and
hcallahan-lowrisc
and removed request for
a team
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging my error and fixing it in #25272, I tidied the code up a bit, using out-of-block definitions and documenting how things worked a little more carefully. This builds on that PR (which contains the first commit) and shouldn't change behaviour, but should make the code a bit easier to reason about.