[sival,bazel] Add SiVal ROM EXT exec env without hyper310 for use in PMOD tests #25404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
force-pushed
the
pmod_sival_tests_fix
branch
from
8f8315f
to
0313a47
Compare
The current SiVAL ROM EXT execution environment uses the hyperdebug (hyper310) interface and bitstream, which does not allow all the pins that are needed for the PMOD tests (e.g. the SPI Macronix flash test) to be used. This commit adds a new execution environment that is private to the PMOD Bazel BUILD file that extends the existing `fpga_cw310_sival_rom_ext` environment to use the universal cw310 bitstream and interface, such that this test can be run with the SiVal changes (e.g. OTP) and in ROM EXT. Signed-off-by: Alex Jones <[email protected]>
AlexJones0
force-pushed
the
pmod_sival_tests_fix
branch
from
0313a47
to
142905d
Compare
jwnrt
reviewed
Nov 26, 2024
I'm not sure, as this change was just to address the failing SiVal nightlies - perhaps @engdoreis would know? |
Only for nightlies. |
engdoreis
approved these changes
Nov 27, 2024
engdoreis
added
the
CherryPick:earlgrey_1.0.0
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a SiVal ROM EXT environment local to the PMOD tests that overrides the
hyper310bitstream and interface to use thecw310versions, so that the relevant pins required for PMOD are accessible during the test, and the test can be run in a ROM EXT environment with the local SiVal changes (e.g. OTP changes). This should work with the existing nightly runner as it uses the samefpga_cw310_sival_rom_exttag, despite being a private exec env.