[hw,lc_ctrl,rtl] Make number of RMA ack signals available at top #25383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
force-pushed
the
darjeeling-lint-fixes
branch
8 times, most recently
from
124e4a6
to
de90423
Compare
Razer6
force-pushed
the
darjeeling-lint-fixes
branch
6 times, most recently
from
0689ea3
to
037cad8
Compare
rswarbrick
reviewed
Nov 27, 2024
Comment on lines
21
to
23
| bind lc_ctrl lc_tx_cov_array_if #( | ||
| .Count(lc_ctrl_dv_utils_pkg::NUM_RMA_ACK_SIGS) | ||
| ) u_lc_flash_rma_ack_i_if ( |
There was a problem hiding this comment.
I'm a bit surprised about this: aren't the two values equal? (The parameter in the design feels less like things are going to change with future modifications)
| lc_tx_t [NumRmaAckSigs-1:0] flash_rma_ack_i; | ||
| lc_tx_t [lc_ctrl_dv_utils_pkg::NUM_RMA_ACK_SIGS-1:0] flash_rma_ack_i; |
There was a problem hiding this comment.
Isn't this the value we're giving the parameter anyway? (and the same question for later hunks)
| int delay_lens[NumRmaAckSigs] = '{default: 0}; | ||
| if (cfg.lc_ctrl_vif.flash_rma_ack_i != {NumRmaAckSigs{val}}) begin | ||
| for (int i = 0; i < NumRmaAckSigs; i++) begin | ||
| int delay_lens[NUM_RMA_ACK_SIGS] = '{default: 0}; |
There was a problem hiding this comment.
(Genuine question:) Can this value be grabbed from the interface with something like cfg.lc_ctrl_vif.NumRmaAckSigs? That way, we know the choice will match.
There was a problem hiding this comment.
I didn't manage to get the right :/
Razer6
force-pushed
the
darjeeling-lint-fixes
branch
from
037cad8
to
3e4831e
Compare
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
darjeeling-lint-fixes
branch
from
3e4831e
to
46c01af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.