Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sival] hash_kat test in crypto testplan #25271

Open
jwnrt opened this issue Nov 20, 2024 · 2 comments · May be fixed by #25333
Open

[sival] hash_kat test in crypto testplan #25271

jwnrt opened this issue Nov 20, 2024 · 2 comments · May be fixed by #25333
Assignees
@nmoroze

Comments

@jwnrt
Copy link
Contributor

jwnrt commented Nov 20, 2024

Description

The crypto testplan for sival points to the //sw/device/tests/crypto/cryptotest:hash_kat target which no longer exists.

This test seems to have been split into a separate test for each kind of hash. If this is the case, the testplan needs to be updated.
@nmoroze
Copy link
Contributor

nmoroze commented Nov 22, 2024

cc @milesdai, I think #25256 takes care of the last instance, it just needs to be cherry-picked to earlgrey_1.0.0 now.

@milesdai
Copy link
Contributor

#25333 performs the cherry-pick

@milesdai milesdai linked a pull request Nov 22, 2024 that will close this issue
Open
@milesdai milesdai linked a pull request Nov 22, 2024 that will close this issue
Cherry-pick to earlgrey_1.0.0: [sival,hmac,kmac] Update test plan and add SHA3-224 test vectors #25333
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmoroze nmoroze

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmoroze @milesdai @jwnrt