Block diagram update #2221
Merged
Block diagram update #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotb-lowrisc
requested changes
Nov 11, 2024
There was a problem hiding this comment.
This looks nice in Inkscape on my local computer, but has problems when rendered on GitHub: https://github.com/lowRISC/ibex/tree/c06a6b5c2efa093e0e5a686e3c208b7a6b37cebf
Note the loss of white background behind the "Instruction Memory Interface" box, the "Instruction Fetch" text is not shown as Exo 2 and is overrunning the edge of its containing box, and the tiny text below the Prefetch Buffer is not rendered at all.
elliotb-lowrisc
requested changes
Nov 11, 2024
|
Ok, I've done the boring thing and moved back to liberation sans. |
elliotb-lowrisc
requested changes
Nov 11, 2024
There was a problem hiding this comment.
- debug_req_i is unreadable on a dark background (e.g. dark-mode GitHub). Suggest increasing size back to what it was and adding either a white outline or background shape.
- Text below Prefetch Buffer not rendering on GitHub. Suggest looking for layer issues.
Nits:
- I liked the
sans-serif"Ibex Core" title better. - "PMP Check" text is rather large (in both places).
marnovandermaas
force-pushed
the
block_diagram_update
branch
from
9542838
to
1e9fb7c
Compare
marnovandermaas
force-pushed
the
block_diagram_update
branch
from
a9ab3ed
to
1be50cf
Compare
hcallahan-lowrisc
approved these changes
Nov 11, 2024
- Move background to its own layer - Make font sizes consistent - Fix icache and pc background Previously the background was morphed around the text, this makes it a background again. - Remove redundant rectangle The instruction memory interface had two rectangles, one black and one purple. I removed the purple one that was bleeding through in the corners. - Instruction fetch alignment The Instruction fetch block was not the same height and was not top aligned with the other blocks. - Align text with boxes This essentially aligns all the text insides the blocks - Standardize lines as 0.265mm The lines between blocks and the ones making the triangular shapes were mostly 0.265mm with a few exceptions. - Stroke width of block outlines same Made all the stroke widths for all the blocks 0.5mm. I've made the outer box a nice round 1.0mm. - Use lowRISC colors E0384F for the background (including the start of the gradient) A21F4F for the outside line - Alignment of in/out arrows Many of these arrows were not aligned, this improves that alignment. - Add white background to instr inf Instruction memory interface lost its white background when the purple outline was removed. This commits adds it back in. - Use Liberation Sans everywhere Exo 2 is not supported natively in browsers and there was no easy way to embed fonts in SVG where Inkscape knew about it. - Fade to white, not transparent - PMP check font is now smaller - Add background to debug request input - Make text under prefetcher bigger so it is rendered on GitHub - Execute text is now its own block so that it is rendered on GitHub
marnovandermaas
force-pushed
the
block_diagram_update
branch
from
0687a8a
to
e3079ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hackday project, which I think improves the block diagram formatting without doing any major re-organization.