Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other Providers + Usage #5

Open
lrljoe opened this issue Jun 13, 2023 · 2 comments
Open

Other Providers + Usage #5

lrljoe opened this issue Jun 13, 2023 · 2 comments

Comments

@lrljoe
Copy link

lrljoe commented Jun 13, 2023

Firstly, thanks for doing this!

Few questions

Q1

Did you resolve the issue of merging ranges?

Q2

Are you open to some contribs for additional providers?

Q3

What are your thoughts on reordering the merged txt file to be slightly cleaner for human eyes

E.g.
Current

13.107.9.0/24
13.64.0.0/12

Proposed

13.64.0.0/12
13.107.9.0/24

Q4

Are you open to an extra JSON approach for the "all merged" files that includes the provider name?

Q5

I'm looking at utilising this in an open source Laravel Package, so it'd be good to be able to contribute a few sources. You happy with that?

@lord-alfred
Copy link
Owner

@lrljoe, I apologize for such a late reply! For some reason I don't get notifications from this repository.

Q1: The ranges are merging using a script, but I'm not sure if this is the optimal way.

Q2: Yes, of course. If you have something to suggest - send PRs (preferably 1 provider = 1 PR)

Q3: I think this is easily done by changing the arguments for the sort command in each downloader + merge. Right now only -h is used

Q4: What's it for? It seems easy enough to convert to json from txt files on your own.

Q5: Which ones sources are we talking about? I don't mind if the ranges from this repository are used wherever needed.

@lord-alfred
Copy link
Owner

@lrljoe ,

Q3: will be corrected after e34eb66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants