Fix: Flatland for Noetic #320
Conversation
There was a problem hiding this comment.
You shouldn't manually edit the files in distro/noetic (except for overrides.nix) because they are automatically generated. Instead, make any necessary changes as overrides in distros/noetic/overrides.nix or distros/ros1-overlay.nix. Additionally, any patches should be submitted upstream before applying them in this overlay. The missing pkg-config dependency can probably be fixed in the long term by submitting a patch upstream to add it to package.xml.
| + #include <lua.h> | ||
| + #include <lualib.h> | ||
| + #include <lauxlib.h> | ||
| +} |
There was a problem hiding this comment.
Why isn't this necessary on Ubuntu? Does the Ubuntu package really compile Lua as C++?
There was a problem hiding this comment.
I'm not sure about Ubuntu package, but Nix derivation seems to compile to C
https://github.com/NixOS/nixpkgs/blob/898cb2064b6e98b8c5499f37e81adbdf2925f7c5/pkgs/development/interpreters/lua-5/interpreter.nix#L85
|
@lopsided98 I moved the changes to |
|
We've encountered the need to add |
Fixes #316