Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fetchAll() to have query arguments #18

Open
2 tasks
zogot opened this issue Dec 2, 2020 · 1 comment
Open
2 tasks

Support for fetchAll() to have query arguments #18

zogot opened this issue Dec 2, 2020 · 1 comment

Comments

@zogot
Copy link

zogot commented Dec 2, 2020

Upon upgrading to the APIv2 it has become clear that there are 2 implementations of fetchAll that reference API Endpoints that support query arguments, but not available as an option in their function.

@ureimers
Copy link

ureimers commented Oct 21, 2021

We're facing the same problem. As our customer has larger projects, we could easily reach the 5000 item limit of Translations::list().

The fix should be simple. Just change:

public function fetchAll($projectId)
{
    return $this->requestAll(
        'GET',
        "projects/$projectId/translations",
        [],
        [],
        'translations'
    );
}

to

public function fetchAll($projectId, $queryParams = [])
{
    return $this->requestAll(
        'GET',
        "projects/$projectId/translations",
        $queryParams,
        [],
        'translations'
    );
}

in Translations.php and Files.php. Just like it is in all other endpoint classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants