Random seed has only 8 bits of entropy #2

Mart-Bogdan · 2024-01-15T13:56:19Z

Current code is using CryproRandom to generate seed, but it uses only single byte

RandomString4Net/RandomString4Net/RandomString.cs

Lines 163 to 175 in f01e288

    
                       byte[] randomSeeds = new byte[1]; 
        
           #if NET6_0_OR_GREATER 
        
                       RandomNumberGenerator randomNumberGenerator = RandomNumberGenerator.Create(); 
        
                       randomNumberGenerator.GetBytes(randomSeeds); 
        
           #else 
        
                       // generating a random seed for the Random() 
        
                       RNGCryptoServiceProvider rngCryptoServiceProvider = new RNGCryptoServiceProvider(); 
        
                       rngCryptoServiceProvider.GetBytes(randomSeeds); 
        
           #endif 
        
                       // creating an instance of Random() using the random seed value 
        
                       Random random = new Random(randomSeeds[0]);

This means that there are possible only 256 different outputs generated by this lib for same input parameters.

Need to take 4 bytes and convert them to int.

jshergal added a commit to jshergal/RandomString4Net that referenced this issue Sep 25, 2024

Updated random seed to use 4 bytes rather than just 1 (Issue ljnath#2)

68fd780

jshergal linked a pull request Sep 25, 2024 that will close this issue

Updated random seed to use 4 bytes rather than just 1 #4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Random seed has only 8 bits of entropy #2

Random seed has only 8 bits of entropy #2

Mart-Bogdan commented Jan 15, 2024

Random seed has only 8 bits of entropy #2

Random seed has only 8 bits of entropy #2

Comments

Mart-Bogdan commented Jan 15, 2024