Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section headings should not be part of following #16

Open
nljelfs opened this issue Jan 16, 2019 · 6 comments
Open

Section headings should not be part of following #16

nljelfs opened this issue Jan 16, 2019 · 6 comments

Comments

@nljelfs
Copy link

nljelfs commented Jan 16, 2019

From the text (which is from Bible Gateway), heading is part of the verse.
For version from Bibles.org, heading is not part of the verse.
And when I make Bible from ebible.org, I make heading part of the verse like Bible Gateway.

Headings are not part of the original Bible text (they are inserted by translators) so I don't think they should be part of the verses in Dove Bible (ie should not be highlighted when a verse is highlighted)

@liudongmiao
Copy link
Owner

And, make subtitle part of verse, so subtitle can be searchable.

@liudongmiao
Copy link
Owner

I'd like heading is part of verse.

  1. it will make heading searchable.
  2. from ebible.org or BibleGateway, heading is part of verse.
  3. Bibles.org don't regard heading as part of verse.

@nljelfs
Copy link
Author

nljelfs commented Jul 6, 2019

Thanks for the update. In case you're not aware, the headings are not part of the original text - they are added by the translators. So I think it's better that they are not part of the verse for highlighting, search, etc.

Is there a technical reason why headings are not searchable unless they are part of a verse? Can the search function be improved to search both headings and verses at the same time?

@liudongmiao liudongmiao reopened this Jul 7, 2019
@liudongmiao
Copy link
Owner

From the original source:

  • BibleGateWay.com, headings are part of the source
  • ebible.org, headings are not part of the source
    • however, I choose to make headings are part of the source when converting to html
  • Bibles.org, headings are not part of the source
    • I can make headings searchable

If headings are part of the source, it can make headings searchable in a very easy way.

Actually, it's possible to make headings not part of the Text, it can be simple:

  • when selection, don't highlight headings, or even remove
  • when share / copy, remove the headings

It may be an option, like this:

  • footnotes (not an option anymore since Dove Bible 0.99+)
  • cross references
  • red letter
  • headings
  • verse number

So, what's your idea for the headings:

  • show?
  • searchable?
  • highlight?
  • copy and share?

@stevebaros
Copy link

Is this repo still maintained ?

@liudongmiao
Copy link
Owner

Yes, however, the latest source code are not uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants