Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix symbol names in fixture examples #606

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: fix symbol names in fixture examples #606

wants to merge 2 commits into from

Conversation

smcoll
Copy link

@smcoll smcoll commented Nov 19, 2024 •
edited
Loading

Description

The variable name for the fixture defined in each of these examples did not match fixture names later in the examples.

@smcoll smcoll requested a review from guacs as a code owner November 19, 2024 20:22
@smcoll smcoll changed the title fix symbol names in test_example_2.py fix symbol names in test_example_2.py and test_example_3.py Nov 19, 2024
@smcoll smcoll changed the title fix symbol names in test_example_2.py and test_example_3.py docs: fix symbol names in fixture examples Nov 19, 2024
@adhtruong
Copy link
Collaborator

adhtruong commented Nov 24, 2024 •
edited
Loading

Hi @smcoll , I'm not sure if this is a mistake. There is internal behaviour to remap the names here. Changing this behaviour wouldn't be backwards compatible so not sure should make this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guacs guacs Awaiting requested review from guacs guacs is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smcoll @adhtruong