Redirect not working

[Saphyel]

I made a mini example of my code to test if Redirect works I copied the code from the docs mainly, so not sure where is the problem

When I access to "/sample" I should get redirected to index, but I'm getting 500.

from litestar import Controller, get, Router, Request
from litestar.exceptions import NotAuthorizedException
from litestar.response import Redirect

class RandomNameController(Controller):
    @get()
    async def index(self, token: str) -> str:
        if not "hola" == token:
            raise NotAuthorizedException()
        return "index"

    @get(path="/sample")
    async def sample(self, token: str) -> Redirect:
        return Redirect(url=f"/?token={token}")

The logs:

 HTTP Request: path=/sample, method=GET, content_type=["",{}], headers={"host":"localhost:8081","user-agent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0","accept":"text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8","accept-language":"en-GB,es-ES;q=0.5","accept-encoding":"gzip, deflate, br","dnt":"1","connection":"keep-alive","upgrade-insecure-requests":"1","sec-fetch-dest":"document","sec-fetch-mode":"navigate","sec-fetch-site":"none","sec-fetch-user":"?1"}, cookies={}, query=token=hola, path_params={}, body=None

[JacobCoffee]

I believe the correct code is

return Redirect(path=f"/?token={token}")

https://docs.litestar.dev/latest/reference/response/redirect.html#module-litestar.response.redirect

[JacobCoffee]

pip install litestar[standard]

Update example code with this replacement:

return Redirect(path=f"/?token={token}")

run and test:

litestar run

visit /sample?token=hola

Here is the MCVE I created.

import uvicorn
from litestar import Litestar, Controller, get
from litestar.exceptions import NotAuthorizedException
from litestar.response import Redirect


class RandomNameController(Controller):
    @get()
    async def index(self, token: str) -> str:
        if token != "hola":
            raise NotAuthorizedException()
        return "index"

    @get(path="/sample")
    async def sample(self, token: str) -> Redirect:
        return Redirect(path=f"/?token={token}")


app = Litestar(route_handlers=[RandomNameController])


if __name__ == "__main__":
    uvicorn.run(app)

[JacobCoffee]

Is this the behavior you are expecting? I can open an issue to fix the docs if so. I am sure it was url at some point, but we can add tests to catch this next time.

[Saphyel]

yes @JacobCoffee that's what I was expecting! Thanks!!! Also thanks for your quick reply!

I'm guessing the docs are wrong => https://docs.litestar.dev/latest/usage/responses.html#redirect-responses