Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the e2es to run with an additional_volume spec #666

Open
Callisto13 opened this issue Mar 10, 2023 · 2 comments
Open

Update the e2es to run with an additional_volume spec #666

Callisto13 opened this issue Mar 10, 2023 · 2 comments
Labels
kind/test Updates to tests only

Comments

@Callisto13
Copy link
Member

Update the e2es with the following patch:

diff --git a/test/e2e/utils/utils.go b/test/e2e/utils/utils.go
index 6f631c2..7a92c6b 100644
--- a/test/e2e/utils/utils.go
+++ b/test/e2e/utils/utils.go
@@ -79,7 +79,8 @@ func PidRunning(pid int) bool {

 func defaultTestMicroVM(name, namespace string) *types.MicroVMSpec {
  var (
-   binImage = "ghcr.io/weaveworks-liquidmetal/flintlock-kernel:5.10.77"
+   binImage = "ghcr.io/weaveworks-liquidmetal/firecracker-kernel-bin:5.10.77"
+   modImage = "ghcr.io/weaveworks-liquidmetal/firecracker-kernel-modules:5.10.77"
    osImage  = "ghcr.io/weaveworks-liquidmetal/capmvm-k8s-os:1.23.5"
  )

@@ -100,6 +101,16 @@ func defaultTestMicroVM(name, namespace string) *types.MicroVMSpec {
        ContainerSource: pointyString(osImage),
      },
    },
+   AdditionalVolumes: []*types.Volume{
+     {
+       Id:         "modules",
+       IsReadOnly: false,
+       Source: &types.VolumeSource{
+         ContainerSource: pointyString(modImage),
+       },
+       MountPoint: pointyString("/lib/modules/5.10.77"),
+     },
+   },
    Interfaces: []*types.NetworkInterface{
      {
        DeviceId: "eth1",

When i have done this so far, something weird has happened when running the tests: the mvm will create, sortof, then flintlock or containerd will go into a really aggressive hot loop somewhere around here. I wasn't able to grab logs at the time, but if I see it again I will.

I have used this feature a bunch and had zero problem, so I wonder if it is something with the tests?

@Callisto13 Callisto13 added the kind/test Updates to tests only label Mar 10, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
Copy link
Contributor

This issue was closed because it has been stalled for 365 days with no activity.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 18, 2024
@richardcase richardcase reopened this Jul 10, 2024
@richardcase richardcase removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test Updates to tests only
Projects
None yet
Development

No branches or pull requests

2 participants