xlsx export buffers in memory

[ihucos]

but it should be streamed

here is the code https://github.com/liqd/adhocracy4/blob/master/adhocracy4/exports/views.py#L19
It should be ok for a while, since we are hosting our own servers we can have plenty of memory per request and its a feature that is not used a lot at once. So this is also a problem where we wait for it come to us before solving it.
Ha but on the other hand since this should be an open source base component we could fix it because in other setups this would not work (more db entries, different hosting)

The easiert solution is probably to buffer it in a file, send the file, then delete it

[fuzzylogic2000]

Also, this will be the problem with the cut off comments?! Good catch!

[ihucos]

I talked with Robert, in our infrastructure we should not run into any kind of problems since we have plenty of RAM per request. If you mean with cut off comments, that the file is incomplete or that there are comments missing, I don't think that problem would be related to this issue.

[fuzzylogic2000]

:(

[ihucos]

Removing a single line: https://github.com/liqd/adhocracy4/blob/master/adhocracy4/exports/views.py#L27
We would buffer the export in a file, but as talked with @treba123 (Robert) that would also not be so nice.

[fuzzylogic2000]

@goapunk Uh, we already have an issue for this. :)

[goapunk]

a rather old one ;-)