Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t440p/w541 move to untested - coreboot configs: bump CONFIG_CBFS_SIZE=0x800000 -> 0xBE4FFF #1826

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Oct 30, 2024

(not sure why it was 8mb as opposed to all other 12mb opaque flash chips)

Probably fixes #1825. Those boards don't build on master since kernel + cryptsetup version bump, sorry it was not caught in PR with all the rebasing: each PR built seperately, but not when rebased on top of each other.

Merging as emergency fix to repel users from flashing from master without external programmer to unbrick if necessary.

…FF (not sure why it was 8mb as opposed to all other 12mb opaque flash chips)

Signed-off-by: Thierry Laurion <[email protected]>
… external programmer for now

repro:
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=w541-hotp-maximized board.move_tested_to_untested
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=w541-maximized board.move_tested_to_untested
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=t440p-hotp-maximized board.move_tested_to_untested
docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:latest -- make BOARD=t440p-maximized board.move_tested_to_untested

Signed-off-by: Thierry Laurion <[email protected]>
@tlaurion tlaurion changed the title t440p/w541 coreboot configs: bump CONFIG_CBFS_SIZE=0x800000 -> 0xBE4FFF t440p/w541 move to untested - coreboot configs: bump CONFIG_CBFS_SIZE=0x800000 -> 0xBE4FFF Oct 30, 2024
@tlaurion tlaurion added the bug label Oct 30, 2024
@tlaurion
Copy link
Collaborator Author

Merging as emergency fix: people not having external flasher won't be compelled to flash internally until tested per board testers.

@tlaurion tlaurion merged commit 744dcca into linuxboot:master Oct 30, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant